Discussion:
[PATCH] readline/search.c: Remove useless parameter '0' for rl_message()
(too old to reply)
Joel Brobecker
2014-09-22 13:03:24 UTC
Permalink
Hi Chen,
gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
rl_message ("%s", p, 0);
~~~~ ^
1 warning generated.
* search.c (_rl_nsearch_init): Remove useless parameter '0' for
rl_message().
Because readline is a separate project from binutils/GDB, we prefer
it if you would first submit the patch to the readline project first
(bug-***@gnu.org, in Cc: of this email), get it accepted there.
Once pushed in the readline project, we can then merge your patch.
Would you mind taking the lead in telling us when the patch is readline?

Thank you!
---
readline/search.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/readline/search.c b/readline/search.c
index 04468fc..bf525e6 100644
--- a/readline/search.c
+++ b/readline/search.c
@@ -210,7 +210,7 @@ _rl_nsearch_init (dir, pchar)
rl_end = rl_point = 0;
p = _rl_make_prompt_for_search (pchar ? pchar : ':');
- rl_message ("%s", p, 0);
+ rl_message ("%s", p);
xfree (p);
RL_SETSTATE(RL_STATE_NSEARCH);
--
1.8.5.2 (Apple Git-48)
--
Joel
Andreas Schwab
2014-09-22 13:06:50 UTC
Permalink
Post by Joel Brobecker
Hi Chen,
gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
rl_message ("%s", p, 0);
~~~~ ^
1 warning generated.
* search.c (_rl_nsearch_init): Remove useless parameter '0' for
rl_message().
Because readline is a separate project from binutils/GDB, we prefer
it if you would first submit the patch to the readline project first
This bug was already fixed in bash 4.3.

Andreas.
--
Andreas Schwab, SUSE Labs, ***@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."
Joel Brobecker
2014-09-22 13:53:12 UTC
Permalink
Post by Andreas Schwab
Post by Joel Brobecker
gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
rl_message ("%s", p, 0);
~~~~ ^
1 warning generated.
* search.c (_rl_nsearch_init): Remove useless parameter '0' for
rl_message().
Because readline is a separate project from binutils/GDB, we prefer
it if you would first submit the patch to the readline project first
This bug was already fixed in bash 4.3.
I see! Sorry about the noise. For my penance, I pushed the patch in.
Do we need it for 7.8.1 as well?
--
Joel
Chen Gang
2014-09-22 15:41:26 UTC
Permalink
Post by Joel Brobecker
Post by Andreas Schwab
Post by Joel Brobecker
gcc -c -DHAVE_CONFIG_H -I. -I../../binutils-gdb/readline -DRL_LIBRARY_VERSION='"6.2"' -g -O2 ../../binutils-gdb/readline/search.c
../../binutils-gdb/readline/search.c:213:24: warning: data argument not used by format string [-Wformat-extra-args]
rl_message ("%s", p, 0);
~~~~ ^
1 warning generated.
* search.c (_rl_nsearch_init): Remove useless parameter '0' for
rl_message().
Because readline is a separate project from binutils/GDB, we prefer
it if you would first submit the patch to the readline project first
OK, thanks, next I shall cc bug-***@gnu.org, when send new patch
for readline.
Post by Joel Brobecker
Post by Andreas Schwab
This bug was already fixed in bash 4.3.
I see! Sorry about the noise.
At least, what you orginally said is useful to me. :-)

And excuse me, my English is not quite well, I am not quite understand
the meaning: "... taking the lead in telling us ...", could you explain
about it in details?

Thanks.
Post by Joel Brobecker
For my penance, I pushed the patch in.
Do we need it for 7.8.1 as well?
Thanks.
--
Chen Gang

Open share and attitude like air water and life which God blessed
Chet Ramey
2014-09-22 16:02:43 UTC
Permalink
Post by Chen Gang
for readline.
Post by Andreas Schwab
This bug was already fixed in bash 4.3.
He meant that it is already changed in the current distributed version
of readline, since bash and readline versions are released together.

Chet
--
``The lyf so short, the craft so long to lerne.'' - Chaucer
``Ars longa, vita brevis'' - Hippocrates
Chet Ramey, ITS, CWRU ***@case.edu http://cnswww.cns.cwru.edu/~chet/
Chen Gang
2014-09-23 02:00:02 UTC
Permalink
Post by Chet Ramey
Post by Chen Gang
for readline.
Post by Andreas Schwab
This bug was already fixed in bash 4.3.
He meant that it is already changed in the current distributed version
of readline, since bash and readline versions are released together.
OK, thanks. But I do not understand the original sentence for:

"Would you mind taking the lead in telling us when the patch is readline?"

Excuse me, I really have no any ideas about it, could you explain it for
details?


Thanks.
--
Chen Gang

Open, share, and attitude like air, water, and life which God blessed
Joel Brobecker
2014-09-23 11:40:03 UTC
Permalink
Post by Chen Gang
"Would you mind taking the lead in telling us when the patch is readline?"
Excuse me, I really have no any ideas about it, could you explain it for
details?
What I meant by that is asking you to take charge of monitoring
the patch status and telling us when it is applied to readline,
so we do not have to do it for you. Since the patch had already
been applied there, this request no longer applies, so there is
nothing left that needs to be done.
--
Joel
Chen Gang
2014-09-23 13:38:35 UTC
Permalink
Post by Joel Brobecker
Post by Chen Gang
"Would you mind taking the lead in telling us when the patch is readline?"
Excuse me, I really have no any ideas about it, could you explain it for
details?
What I meant by that is asking you to take charge of monitoring
the patch status and telling us when it is applied to readline,
so we do not have to do it for you. Since the patch had already
been applied there, this request no longer applies, so there is
nothing left that needs to be done.
OK, thank you very much.

And sorry for bothering other members by my questions (which is just
spam to other members).


Thanks.
--
Chen Gang

Open share and attitude like air water and life which God blessed
Jan Kratochvil
2014-09-22 13:07:44 UTC
Permalink
Post by Joel Brobecker
Because readline is a separate project from binutils/GDB, we prefer
it if you would first submit the patch to the readline project first
Once pushed in the readline project, we can then merge your patch.
Would you mind taking the lead in telling us when the patch is readline?
It already is:
http://git.savannah.gnu.org/cgit/bash.git/diff/lib/readline/search.c?h=devel&id=d76edd307c1e53bcf497723365dfa1e31b0f1325


Jan
Loading...